Execute shared UnivMon frequency summaries and raw HLL updates - #617
Merged
Merged
Conversation
This was referenced Sep 11, 2026
This was referenced Sep 11, 2026
zzylol
marked this pull request as ready for review
September 11, 2026 13:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planner-selected HLL and UnivMon summaries need executable ingest, storage and readout paths in the backend.
Add raw-value HLL updates and a shared UnivMon accumulator for count, distinct, frequency L2 and entropy. Both use SummaryCatalog partitioning, SummaryStore panes and QueryPlan bindings. Installation validates scalar hashing versus unit-frequency input semantics; unknown approximate guarantees remain uncalibrated.
Before this PR: HLL had no raw updater, UnivMon could not execute, and unsupported Theta/KMV emission could panic.
After this PR: per-series HLL and shared UnivMon states can be built, serialized, merged and read through the installed DAG. Unsupported families fail admission. This does not establish fallback coverage for every approximate subtree.
Verification: latest integration using the pinned #139 dependency passed 84 shared-type tests, 726 control-plane tests, 1,123 data-plane tests, and all 9 real-process compatibility tests (13.16 seconds). Independent review passed for the main integration and terminal-state guard/dependency pin. Exact-head remote CI is pending.
#620's terminal-mode restore guard is now included. CI pins ProjectASAP/asap_sketchlib#139 at
c0de315754f9a6c77dd7a25aca0b2b62f0aec276; local builds must use the same sibling checkout as the collector adapter. This explicitly depends on the unmerged library revision, as documented indocs/developer_docs/univmon-dependency.md. #616 is merged. Readout calibration and measured benefits are tracked separately in #619/#626; this PR makes no general speedup claim.